Cleanup Phase 3: Fix null/undefined access with safe type assertions#2707
Merged
zanesq merged 2 commits intofix/typescript-errors-phase2-unused-variablesfrom May 29, 2025
Conversation
- Fix AlertBox.tsx: Add non-null assertions for alert.progress properties (safe because already guarded by alert.progress ? check) - Fix ConfigContext.tsx: Add optional chaining for API response data access - response.data?.config, configResponse.data?.config - extensionsResponse.data?.extensions with fallback to empty array - Fix App.tsx: Correct extractRemoteUrl return type to string | null (URLSearchParams.get() returns string | null, not string) - Fix SearchBar.tsx: Improve null checks for localSearchResults access - Better conditional logic to handle undefined count property - Bonus: Comprehensive asset type declarations in json.d.ts - Added PNG, JPG, GIF, SVG, MP3, MP4 module declarations - Fixes all asset import TypeScript errors - Reduces TypeScript errors by 11 (from 361 to 350) - Uses proper TypeScript patterns: optional chaining (?.) and non-null assertions (!) - All changes are conservative and preserve existing runtime behavior
alexhancock
approved these changes
May 29, 2025
zanesq
merged commit df75074
into
fix/typescript-errors-phase2-unused-variables
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix AlertBox.tsx: Add non-null assertions for alert.progress properties (safe because already guarded by alert.progress ? check)
Fix ConfigContext.tsx: Add optional chaining for API response data access
Fix App.tsx: Correct extractRemoteUrl return type to string | null (URLSearchParams.get() returns string | null, not string)
Fix SearchBar.tsx: Improve null checks for localSearchResults access
Bonus: Comprehensive asset type declarations in json.d.ts
Reduces TypeScript errors by 11 (from 361 to 350)
Uses proper TypeScript patterns: optional chaining (?.) and non-null assertions (!)
All changes are conservative and preserve existing runtime behavior